From ac0f599cabf53cef51fc2deaf2994b1a1b1fa11d Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Mon, 7 Aug 2023 16:51:21 +1200 Subject: [PATCH] s3:winbindd: Add missing newlines to logging messages Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- source3/winbindd/idmap_autorid_tdb.c | 6 +++--- source3/winbindd/idmap_ldap.c | 4 ++-- source3/winbindd/winbindd_cache.c | 2 +- source3/winbindd/winbindd_cm.c | 2 +- source3/winbindd/winbindd_dual.c | 8 ++++---- source3/winbindd/winbindd_dual_ndr.c | 10 +++++----- source3/winbindd/winbindd_pam.c | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-) diff --git a/source3/winbindd/idmap_autorid_tdb.c b/source3/winbindd/idmap_autorid_tdb.c index fb195367da6..6c76764076a 100644 --- a/source3/winbindd/idmap_autorid_tdb.c +++ b/source3/winbindd/idmap_autorid_tdb.c @@ -100,12 +100,12 @@ static NTSTATUS idmap_autorid_addrange_action(struct db_context *db, requested_rangenum = range->rangenum; if (db == NULL) { - DEBUG(3, ("Invalid database argument: NULL")); + DEBUG(3, ("Invalid database argument: NULL\n")); return NT_STATUS_INVALID_PARAMETER; } if (range == NULL) { - DEBUG(3, ("Invalid range argument: NULL")); + DEBUG(3, ("Invalid range argument: NULL\n")); return NT_STATUS_INVALID_PARAMETER; } @@ -355,7 +355,7 @@ static NTSTATUS idmap_autorid_getrange_int(struct db_context *db, status = idmap_autorid_loadconfig(db, &globalcfg); if (!NT_STATUS_IS_OK(status)) { - DEBUG(1, ("Failed to read global configuration")); + DEBUG(1, ("Failed to read global configuration\n")); goto done; } range->low_id = globalcfg.minvalue diff --git a/source3/winbindd/idmap_ldap.c b/source3/winbindd/idmap_ldap.c index ee12f04c1a9..0b0d82bba36 100644 --- a/source3/winbindd/idmap_ldap.c +++ b/source3/winbindd/idmap_ldap.c @@ -942,7 +942,7 @@ again: } filter = talloc_asprintf_append_buffer(filter, "))"); CHECK_ALLOC_DONE(filter); - DEBUG(10, ("Filter: [%s]", filter)); + DEBUG(10, ("Filter: [%s]\n", filter)); } else { bidx = 0; idx = 1; @@ -1006,7 +1006,7 @@ again: map = idmap_find_map_by_sid(&ids[bidx], &sid); if (!map) { DEBUG(2, ("WARNING: couldn't find entry sid (%s) " - "in ids", sidstr)); + "in ids\n", sidstr)); TALLOC_FREE(sidstr); continue; } diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c index a16eaa50219..ca2341ef456 100644 --- a/source3/winbindd/winbindd_cache.c +++ b/source3/winbindd/winbindd_cache.c @@ -3251,7 +3251,7 @@ bool initialize_winbindd_cache(void) } if (unlink(db_path) == -1) { - DBG_ERR("initialize_winbindd_cache: unlink %s failed %s ", + DBG_ERR("initialize_winbindd_cache: unlink %s failed %s\n", db_path, strerror(errno) ); TALLOC_FREE(db_path); diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c index 9f56596669b..2fab9ceadf7 100644 --- a/source3/winbindd/winbindd_cm.c +++ b/source3/winbindd/winbindd_cm.c @@ -3326,7 +3326,7 @@ void winbind_msg_ip_dropped(struct messaging_context *msg_ctx, */ slash = strchr(addr, '/'); if (slash == NULL) { - DEBUG(1, ("invalid msg_ip_dropped message: %s", + DEBUG(1, ("invalid msg_ip_dropped message: %s\n", addr)); return; } diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c index 36562ab10b8..dadae1d3eda 100644 --- a/source3/winbindd/winbindd_dual.c +++ b/source3/winbindd/winbindd_dual.c @@ -1252,7 +1252,7 @@ static bool calculate_next_machine_pwd_change(const char *domain, NULL); if (pw == NULL) { - DEBUG(0,("cannot fetch own machine password ????")); + DEBUG(0,("cannot fetch own machine password ????\n")); return false; } @@ -1984,7 +1984,7 @@ bool winbindd_setup_sig_term_handler(bool parent) winbindd_sig_term_handler, is_parent); if (!se) { - DEBUG(0,("failed to setup SIGTERM handler")); + DEBUG(0,("failed to setup SIGTERM handler\n")); talloc_free(is_parent); return false; } @@ -1995,7 +1995,7 @@ bool winbindd_setup_sig_term_handler(bool parent) winbindd_sig_term_handler, is_parent); if (!se) { - DEBUG(0,("failed to setup SIGINT handler")); + DEBUG(0,("failed to setup SIGINT handler\n")); talloc_free(is_parent); return false; } @@ -2006,7 +2006,7 @@ bool winbindd_setup_sig_term_handler(bool parent) winbindd_sig_term_handler, is_parent); if (!se) { - DEBUG(0,("failed to setup SIGINT handler")); + DEBUG(0,("failed to setup SIGINT handler\n")); talloc_free(is_parent); return false; } diff --git a/source3/winbindd/winbindd_dual_ndr.c b/source3/winbindd/winbindd_dual_ndr.c index 48b5297f57e..cf54d998891 100644 --- a/source3/winbindd/winbindd_dual_ndr.c +++ b/source3/winbindd/winbindd_dual_ndr.c @@ -465,14 +465,14 @@ static NTSTATUS set_remote_addresses(struct dcesrv_connection *conn, ret = getpeername(sock, sar, &sa_len); if (ret != 0) { status = map_nt_error_from_unix(ret); - DBG_ERR("getpeername failed: %s", nt_errstr(status)); + DBG_ERR("getpeername failed: %s\n", nt_errstr(status)); return status; } ret = tsocket_address_bsd_from_sockaddr(conn, sar, sa_len, &remote); if (ret != 0) { status = map_nt_error_from_unix(ret); - DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s", + DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s\n", nt_errstr(status)); return status; } @@ -481,14 +481,14 @@ static NTSTATUS set_remote_addresses(struct dcesrv_connection *conn, ret = getsockname(sock, sar, &sa_len); if (ret != 0) { status = map_nt_error_from_unix(ret); - DBG_ERR("getsockname failed: %s", nt_errstr(status)); + DBG_ERR("getsockname failed: %s\n", nt_errstr(status)); return status; } ret = tsocket_address_bsd_from_sockaddr(conn, sar, sa_len, &local); if (ret != 0) { status = map_nt_error_from_unix(ret); - DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s", + DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s\n", nt_errstr(status)); return status; } @@ -541,7 +541,7 @@ enum winbindd_result winbindd_dual_ndrcmd(struct winbindd_domain *domain, mem_ctx = talloc_stackframe(); if (mem_ctx == NULL) { - DBG_ERR("No memory"); + DBG_ERR("No memory\n"); return WINBINDD_ERROR; } diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c index 66d5b4a5a7b..9efbeb08d18 100644 --- a/source3/winbindd/winbindd_pam.c +++ b/source3/winbindd/winbindd_pam.c @@ -2169,7 +2169,7 @@ static void log_authentication( client_name, client_pid); if (ui->auth_description == NULL) { - DBG_ERR("OOM Unable to create auth_description"); + DBG_ERR("OOM Unable to create auth_description\n"); } ui->client.account_name = user_name; ui->client.domain_name = domain_name;