From ad19dd100f6a6e2d4b80ac761902a4aed992935b Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Fri, 3 Mar 2023 12:02:35 +1300 Subject: [PATCH] tests/krb5: Make arguments to get_target() keyword arguments This avoids mistakes by ensuring that passed-in arguments go to their intended destinations. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- python/samba/tests/krb5/group_tests.py | 6 ++++-- python/samba/tests/krb5/kdc_base_test.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/python/samba/tests/krb5/group_tests.py b/python/samba/tests/krb5/group_tests.py index 1090e59bea2..d7f2264ebdc 100755 --- a/python/samba/tests/krb5/group_tests.py +++ b/python/samba/tests/krb5/group_tests.py @@ -1828,7 +1828,8 @@ class GroupTests(KDCBaseTest): ts_enc_padata = self.get_enc_timestamp_pa_data_from_key(preauth_key) padata = [ts_enc_padata] - target_creds, sname = self.get_target(as_to_krbtgt, as_compression) + target_creds, sname = self.get_target(as_to_krbtgt, + compression=as_compression) decryption_key = self.TicketDecryptionKey_from_creds(target_creds) target_supported_etypes = target_creds.tgs_supported_enctypes @@ -1914,7 +1915,8 @@ class GroupTests(KDCBaseTest): set_user_flags=tgs_set_user_flags, reset_user_flags=tgs_reset_user_flags) - target_creds, sname = self.get_target(tgs_to_krbtgt, tgs_compression) + target_creds, sname = self.get_target(tgs_to_krbtgt, + compression=tgs_compression) decryption_key = self.TicketDecryptionKey_from_creds(target_creds) subkey = self.RandomKey(ticket.session_key.etype) diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py index 4f0725f10b3..5e2d7747e95 100644 --- a/python/samba/tests/krb5/kdc_base_test.py +++ b/python/samba/tests/krb5/kdc_base_test.py @@ -1825,7 +1825,7 @@ class KDCBaseTest(RawKerberosTest): # Get the credentials and server principal name of either the krbtgt, or a # specially created account, with resource SID compression either supported # or unsupported. - def get_target(self, to_krbtgt, compression=None, extra_enctypes=0): + def get_target(self, to_krbtgt, *, compression=None, extra_enctypes=0): if to_krbtgt: self.assertIsNone(compression, "it's no good specifying compression support "