sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-30 17:49:30 +03:00
Code Activity

Don't leak: Use a temporary context for the admin token and free it.

Browse Source 
Michael
(This used to be commit 9d7502115e)
This commit is contained in:
Michael Adam
2008-01-03 01:26:31 +01:00
parent 3c9f7c7a64
commit ad1cc905b2
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source3/libnet/libnet_conf.c
View File

@ -64,6 +64,7 @@ static WERROR libnet_smbconf_reg_open_path(TALLOC_CTX *mem_ctx,
{ {
WERROR werr = WERR_OK; WERROR werr = WERR_OK;
NT_USER_TOKEN *token; NT_USER_TOKEN *token;
TALLOC_CTX *tmp_ctx = NULL;
if (path == NULL) { if (path == NULL) {
DEBUG(1, ("Error: NULL path string given\n")); DEBUG(1, ("Error: NULL path string given\n"));
@ -71,7 +72,13 @@ static WERROR libnet_smbconf_reg_open_path(TALLOC_CTX *mem_ctx,
goto done; goto done;
} }
token = registry_create_admin_token(mem_ctx); tmp_ctx = talloc_new(mem_ctx);
if (tmp_ctx == NULL) {
werr = WERR_NOMEM;
goto done;
}
token = registry_create_admin_token(tmp_ctx);
if (token == NULL) { if (token == NULL) {
DEBUG(1, ("Error creating admin token\n")); DEBUG(1, ("Error creating admin token\n"));
/* what is the appropriate error code here? */ /* what is the appropriate error code here? */
@ -87,6 +94,7 @@ static WERROR libnet_smbconf_reg_open_path(TALLOC_CTX *mem_ctx,
} }
done: done:
TALLOC_FREE(tmp_ctx);
return werr; return werr;
} }