1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00

s3:smbd: consistently use DLIST_ADD* to fill client->connections in smbd_add_connection()

We should not just overwrite the client->connections pointer if we
reject the connection.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
This commit is contained in:
Stefan Metzmacher 2020-06-25 22:42:18 +02:00
parent 4d92452890
commit ad3c5c1a62

View File

@ -3866,7 +3866,7 @@ NTSTATUS smbd_add_connection(struct smbXsrv_client *client, int sock_fd,
* so that the caller can return an error message
* to the client
*/
client->connections = xconn;
DLIST_ADD_END(client->connections, xconn);
xconn->client = client;
talloc_steal(client, xconn);