sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

s3-shadow-copy2: Remove TODO and fix comments

Browse Source 
The patch "s3-shadow-copy2: Fix dir/@GMT-2012.10.15-13.48.43 form of
paths" takes care of a case marked as TODO, remove it and adjust the
comments accordingly.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Christof Schmitt 2014-06-26 12:43:03 -07:00 committed by Volker Lendecke
parent 16a6181289
commit b053d4b3f9
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
source3/modules/vfs_shadow_copy2.c
View File

@ -264,7 +264,12 @@ static bool shadow_copy2_strip_snapshot(TALLOC_CTX *mem_ctx,
goto no_snapshot;
}
if (q[0] == '\0') {
/* the name consists of only the GMT token */
/*
* The name consists of only the GMT token or the GMT
* token is at the end of the path. XP seems to send
* @GMT- at the end under certain circumstances even
* with a path prefix.
*/
if (pstripped != NULL) {
stripped = talloc_strndup(mem_ctx, name, p - name);
if (stripped == NULL) {
@ -277,12 +282,8 @@ static bool shadow_copy2_strip_snapshot(TALLOC_CTX *mem_ctx,
}
if (q[0] != '/') {
/*
* The GMT token is either at the end of the path
* or it is not a complete path component, i.e. the
* path component continues after the gmt-token.
*
* TODO: Is this correct? Or would the GMT tag as the
* last component be a valid input?
* It is not a complete path component, i.e. the path
* component continues after the gmt-token.
*/
DEBUG(10, ("q[0] = %d\n", (int)q[0]));
goto no_snapshot;