sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-08 05:57:51 +03:00
Code

s3/smbd: fix FSCTL_SET_SPARSE permission checks

Browse Source 
On Windows servers (tested against Windows Server 2008 & 2012) the
FSCTL_SET_SPARSE ioctl is processed if FILE_WRITE_DATA,
FILE_WRITE_ATTRIBUTES _or_ SEC_FILE_APPEND_DATA permissions are granted
on the open file-handle.
Fix Samba such that it matches this behaviour, rather than only checking
for FILE_WRITE_DATA or FILE_WRITE_ATTRIBUTES.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
David Disseldorp 2015-02-23 20:27:37 +01:00 committed by Jeremy Allison
parent 55d8ac5280
commit b0e5a4ebde
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source3/smbd/dosmode.c
View File

@ -876,8 +876,13 @@ NTSTATUS file_set_sparse(connection_struct *conn,
return NT_STATUS_MEDIA_WRITE_PROTECTED; return NT_STATUS_MEDIA_WRITE_PROTECTED;
} }
if (!(fsp->access_mask & FILE_WRITE_DATA) && /*
!(fsp->access_mask & FILE_WRITE_ATTRIBUTES)) { * Windows Server 2008 & 2012 permit FSCTL_SET_SPARSE if any of the
* following access flags are granted.
*/
if ((fsp->access_mask & (FILE_WRITE_DATA
| FILE_WRITE_ATTRIBUTES
| SEC_FILE_APPEND_DATA)) == 0) {
DEBUG(9,("file_set_sparse: fname[%s] set[%u] " DEBUG(9,("file_set_sparse: fname[%s] set[%u] "
"access_mask[0x%08X] - access denied\n", "access_mask[0x%08X] - access denied\n",
smb_fname_str_dbg(fsp->fsp_name), smb_fname_str_dbg(fsp->fsp_name),