sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-03 13:47:25 +03:00
Code

rodc/dns: Do not put a trailing dot at end of a DNS record

Browse Source 
This causes RESOLV_WRAPPER to not detect the record correctly (while
also creating inconsistent and possibly breaking records).

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Garming Sam 2017-03-29 13:16:48 +13:00 committed by Garming Sam
parent 58113e5bc9
commit b10ee68600
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
source4/dsdb/dns/dns_update.c
View File

@ -531,36 +531,35 @@ static NTSTATUS dnsupdate_dnsupdate_RODC(struct irpc_message *msg,
return NT_STATUS_OK;
}
for (i=0; i<st->r->in.dns_names->count; i++) {
struct NL_DNS_NAME_INFO *n = &r->in.dns_names->names[i];
switch (n->type) {
case NlDnsLdapAtSite:
dprintf(st->fd, "SRV _ldap._tcp.%s._sites.%s. %s %u\n",
dprintf(st->fd, "SRV _ldap._tcp.%s._sites.%s %s %u\n",
site, dnsdomain, hostname, n->port);
break;
case NlDnsGcAtSite:
dprintf(st->fd, "SRV _ldap._tcp.%s._sites.gc._msdcs.%s. %s %u\n",
dprintf(st->fd, "SRV _ldap._tcp.%s._sites.gc._msdcs.%s %s %u\n",
site, dnsdomain, hostname, n->port);
break;
case NlDnsDsaCname:
dprintf(st->fd, "CNAME %s._msdcs.%s. %s\n",
dprintf(st->fd, "CNAME %s._msdcs.%s %s\n",
ntdsguid, dnsforest, hostname);
break;
case NlDnsKdcAtSite:
dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.dc._msdcs.%s. %s %u\n",
dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.dc._msdcs.%s %s %u\n",
site, dnsdomain, hostname, n->port);
break;
case NlDnsDcAtSite:
dprintf(st->fd, "SRV _ldap._tcp.%s._sites.dc._msdcs.%s. %s %u\n",
dprintf(st->fd, "SRV _ldap._tcp.%s._sites.dc._msdcs.%s %s %u\n",
site, dnsdomain, hostname, n->port);
break;
case NlDnsRfc1510KdcAtSite:
dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.%s. %s %u\n",
dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.%s %s %u\n",
site, dnsdomain, hostname, n->port);
break;
case NlDnsGenericGcAtSite:
dprintf(st->fd, "SRV _gc._tcp.%s._sites.%s. %s %u\n",
dprintf(st->fd, "SRV _gc._tcp.%s._sites.%s %s %u\n",
site, dnsforest, hostname, n->port);
break;
}