From b2b7e3b9710fa22716f931177265dcd8de74532b Mon Sep 17 00:00:00 2001 From: Ralph Boehme Date: Tue, 11 Jul 2017 20:41:43 +0200 Subject: [PATCH] ctdbd_conn: pass persistent bool instead of tdb_flags ctdbd_db_attach() only needs to know the ctdb database model, not the rest of the flags. Bug: https://bugzilla.samba.org/show_bug.cgi?id=12891 Signed-off-by: Ralph Boehme Reviewed-by: Amitay Isaacs --- source3/include/ctdbd_conn.h | 2 +- source3/lib/ctdbd_conn.c | 3 +-- source3/lib/dbwrap/dbwrap_ctdb.c | 5 +++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/source3/include/ctdbd_conn.h b/source3/include/ctdbd_conn.h index 06fbcc373a4..38477d313de 100644 --- a/source3/include/ctdbd_conn.h +++ b/source3/include/ctdbd_conn.h @@ -55,7 +55,7 @@ char *ctdbd_dbpath(struct ctdbd_connection *conn, TALLOC_CTX *mem_ctx, uint32_t db_id); int ctdbd_db_attach(struct ctdbd_connection *conn, const char *name, - uint32_t *db_id, int tdb_flags); + uint32_t *db_id, bool persistent); int ctdbd_migrate(struct ctdbd_connection *conn, uint32_t db_id, TDB_DATA key); diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c index 70d3d83f031..b81feca65ba 100644 --- a/source3/lib/ctdbd_conn.c +++ b/source3/lib/ctdbd_conn.c @@ -819,12 +819,11 @@ char *ctdbd_dbpath(struct ctdbd_connection *conn, * attach to a ctdb database */ int ctdbd_db_attach(struct ctdbd_connection *conn, - const char *name, uint32_t *db_id, int tdb_flags) + const char *name, uint32_t *db_id, bool persistent) { int ret; TDB_DATA data; int32_t cstatus; - bool persistent = (tdb_flags & TDB_CLEAR_IF_FIRST) == 0; data = string_term_tdb_data(name); diff --git a/source3/lib/dbwrap/dbwrap_ctdb.c b/source3/lib/dbwrap/dbwrap_ctdb.c index 001d2c42fb2..07e35f8ffb0 100644 --- a/source3/lib/dbwrap/dbwrap_ctdb.c +++ b/source3/lib/dbwrap/dbwrap_ctdb.c @@ -1780,6 +1780,7 @@ struct db_context *db_open_ctdb(TALLOC_CTX *mem_ctx, char *db_path; struct loadparm_context *lp_ctx; TDB_DATA data; + bool persistent = (tdb_flags & TDB_CLEAR_IF_FIRST); int32_t cstatus; int ret; @@ -1811,7 +1812,7 @@ struct db_context *db_open_ctdb(TALLOC_CTX *mem_ctx, db_ctdb->db = result; db_ctdb->conn = conn; - ret = ctdbd_db_attach(db_ctdb->conn, name, &db_ctdb->db_id, tdb_flags); + ret = ctdbd_db_attach(db_ctdb->conn, name, &db_ctdb->db_id, persistent); if (ret != 0) { DEBUG(0, ("ctdbd_db_attach failed for %s: %s\n", name, strerror(ret))); @@ -1836,7 +1837,7 @@ struct db_context *db_open_ctdb(TALLOC_CTX *mem_ctx, db_path = ctdbd_dbpath(db_ctdb->conn, db_ctdb, db_ctdb->db_id); - result->persistent = ((tdb_flags & TDB_CLEAR_IF_FIRST) == 0); + result->persistent = persistent; result->lock_order = lock_order; /* only pass through specific flags */