sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-11-26 04:23:49 +03:00
Code Activity

winbind cache: Don't create SN cache entries during name-to-sid queries.

Browse Source 
Clients can request name-to-sid queries for different combinations of
upper and lower case names. We don't want to create the reverse caching
entries for each combination used.

This avoids inconsistent answers on sid-to-name queries.

Please review!

Karolin
This commit is contained in:
Karolin Seeger
2008-06-16 15:21:28 +02:00
parent 1f86c7a2a1
commit b58e4f6b3d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
source/winbindd/winbindd_cache.c
View File

@@ -1451,13 +1451,13 @@ do_query:
if (domain->online &&
(NT_STATUS_IS_OK(status) || NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED))) {
wcache_save_name_to_sid(domain, status, domain_name, name, sid, *type);
/* Don't add SN cache entries for sid-to-name queries during this operation.
* It leads to inconsistent answers during sid-to-name queries as the
* client can ask for different combinations of lower case and upper case
* names in these name-to-sid queries.
*/
/* Only save the reverse mapping if this was not a UPN */
if (!strchr(name, '@')) {
strupper_m(CONST_DISCARD(char *,domain_name));
strlower_m(CONST_DISCARD(char *,name));
wcache_save_sid_to_name(domain, status, sid, domain_name, name, *type);
}
}
return status;