sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-11-28 12:23:49 +03:00
Code Activity

r9619: Fix messages_pending_for_pid actually do what it's meant to do. This might be

Browse Source 
a big relief on messages.tdb contention as ignoring processes with >1000
messages in printing/notify.c should work correctly now.

Jeremy, Jerry told me to ask you about printer scalability torture tests, this
might be a reason why you implemented the message_send_pid_with_timeout
using the signal (shudder) in the first place. :-)

While looking at that... Wouldn't it be better to not use the signal but have
an overall timeout for print_notify_send_messages using GetTimeOfDay & friends
and not use the alarm signal deep inside tdb.c?

Volker
This commit is contained in:
Volker Lendecke
2005-08-25 17:46:13 +00:00
committed by Gerald (Jerry) Carter
parent a94de276ae
commit b5e82bb512
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source/lib/messages.c
View File

@@ -314,7 +314,7 @@ unsigned int messages_pending_for_pid(pid_t pid)
char *buf;
unsigned int message_count = 0;
kbuf = message_key_pid(sys_getpid());
kbuf = message_key_pid(pid);
dbuf = tdb_fetch(tdb, kbuf);
if (dbuf.dptr == NULL || dbuf.dsize == 0) {