From b8fe8a5fd277f60ccc07ac64dff067255aff4f11 Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Wed, 16 Oct 2024 12:23:42 +1100 Subject: [PATCH] ctdb-scripts: Drop TCP tuning comments from statd_callout_helper Commits caad5dc38d790d76f6720b312c1557ec3151a084 and f022df1d40c9c1e3e528f178204f404ee395d5c2 commented out these lines back in 2007. 2 things are clear from the commit messages: * These setting should not be required in the real world - they are: mainly useful for avoiding ack-storms when doing very rapid failover/failback during testing * If they are needed, they are not specific to statd_callout/statd_callout_helper Let's remove these comments to avoid confusing people. Reported-by: Ulrich Sibiller Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs --- ctdb/tools/statd_callout_helper | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ctdb/tools/statd_callout_helper b/ctdb/tools/statd_callout_helper index a6ceb56aab9..7bf747d1b25 100755 --- a/ctdb/tools/statd_callout_helper +++ b/ctdb/tools/statd_callout_helper @@ -207,12 +207,6 @@ notify) # conflicting locks through other nodes before all locks have been # reclaimed) - # we need these settings to make sure that no tcp connections survive - # across a very fast failover/failback - #echo 10 > /proc/sys/net/ipv4/tcp_fin_timeout - #echo 0 > /proc/sys/net/ipv4/tcp_max_tw_buckets - #echo 0 > /proc/sys/net/ipv4/tcp_max_orphans - # Delete the notification list for statd, we don't want it to # ping any clients dir=$(find_statd_sm_dir)