From bba1613d55265c52d2632597a7076938b5a42504 Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Mon, 7 Aug 2023 16:37:19 +1200 Subject: [PATCH] s3:libsmb: Add missing newlines to logging messages Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- source3/libsmb/clidfs.c | 2 +- source3/libsmb/cliprint.c | 2 +- source3/libsmb/libsmb_path.c | 4 ++-- source3/libsmb/libsmb_server.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/source3/libsmb/clidfs.c b/source3/libsmb/clidfs.c index 4321c216473..04c82e82575 100644 --- a/source3/libsmb/clidfs.c +++ b/source3/libsmb/clidfs.c @@ -182,7 +182,7 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx, if (!NT_STATUS_IS_OK(status)) { if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) { - DBG_ERR("NetBIOS support disabled, unable to connect"); + DBG_ERR("NetBIOS support disabled, unable to connect\n"); } DBG_WARNING("Connection to %s failed (Error %s)\n", diff --git a/source3/libsmb/cliprint.c b/source3/libsmb/cliprint.c index c4ee3420e73..2e51dabdf32 100644 --- a/source3/libsmb/cliprint.c +++ b/source3/libsmb/cliprint.c @@ -41,7 +41,7 @@ static const char *fix_char_ptr(unsigned int datap, unsigned int converter, offset = datap - converter; if (offset >= rdrcnt) { - DEBUG(1,("bad char ptr: datap=%u, converter=%u rdrcnt=%d>", + DEBUG(1,("bad char ptr: datap=%u, converter=%u rdrcnt=%d>\n", datap, converter, rdrcnt)); return ""; } diff --git a/source3/libsmb/libsmb_path.c b/source3/libsmb/libsmb_path.c index 9d4599acf57..d53c772174c 100644 --- a/source3/libsmb/libsmb_path.c +++ b/source3/libsmb/libsmb_path.c @@ -262,7 +262,7 @@ SMBC_parse_path(TALLOC_CTX *ctx, /* Watch the test below, we are testing to see if we should exit */ if (strncmp(p, "//", 2) && strncmp(p, "\\\\", 2)) { - DEBUG(1, ("Invalid path (does not begin with smb://")); + DEBUG(1, ("Invalid path (does not begin with smb://\n")); return -1; } @@ -273,7 +273,7 @@ SMBC_parse_path(TALLOC_CTX *ctx, /* There are options. Null terminate here and point to them */ *q++ = '\0'; - DEBUG(4, ("Found options '%s'", q)); + DEBUG(4, ("Found options '%s'\n", q)); /* Copy the options */ if (pp_options && *pp_options != NULL) { diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c index 1e8e5aec253..a65f0f356c3 100644 --- a/source3/libsmb/libsmb_server.c +++ b/source3/libsmb/libsmb_server.c @@ -546,7 +546,7 @@ SMBC_server_internal(TALLOC_CTX *ctx, if (!NT_STATUS_IS_OK(status)) { if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) { - DBG_ERR("NetBIOS support disabled, unable to connect"); + DBG_ERR("NetBIOS support disabled, unable to connect\n"); } errno = map_errno_from_nt_status(status);