sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

Revert "smbd: explain that/why we use the raw tevent_context for lease_timeout_handler()"

Browse Source 
This reverts commit 52f098d38d.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Ralph Boehme 2018-12-27 15:24:37 +01:00 committed by Stefan Metzmacher
parent 4036fc894f
commit bcb4723aac
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source3/smbd/oplock.c
View File

@ -354,11 +354,6 @@ static void lease_timeout_handler(struct tevent_context *ctx,
struct share_mode_lock *lck;
uint16_t old_epoch = lease->lease.lease_epoch;
/*
* This function runs without any specific impersonation
* and must not call any SMB_VFS operations!
*/
fsp = file_find_one_fsp_from_lease_key(lease->sconn,
&lease->lease.lease_key);
if (fsp == NULL) {
@ -454,12 +449,7 @@ bool fsp_lease_update(struct share_mode_lock *lck,
DEBUG(10,("%s: setup timeout handler\n", __func__));
/*
* lease_timeout_handler() only accesses locking.tdb
* so we don't use any impersonation and use
* the raw tevent context.
*/
lease->timeout = tevent_add_timer(lease->sconn->raw_ev_ctx,
lease->timeout = tevent_add_timer(lease->sconn->ev_ctx,
lease, t,
lease_timeout_handler,
lease);