sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

smbd: Simplify filename_convert_dirfsp()

Browse Source 
If we do the S_ISLNK check in the lower level, the if-condition is
simpler and we get the close_file_free() call for free.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Volker Lendecke 2024-10-08 15:51:06 +02:00 committed by Ralph Boehme
parent 3ab6a9a9bf
commit bd30c9c128
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
source3/smbd/filename.c
View File

@ -1033,6 +1033,13 @@ static NTSTATUS filename_convert_dirfsp_nosymlink(
}
done:
if (S_ISLNK(smb_fname->st.st_ex_mode) &&
!(ucf_flags & UCF_LCOMP_LNK_OK)) {
status = NT_STATUS_STOPPED_ON_SYMLINK;
*_symlink_err = symlink_err;
goto fail;
}
*_dirfsp = smb_dirname->fsp;
*_smb_fname = smb_fname;
*_symlink_err = symlink_err;
@ -1090,18 +1097,6 @@ next:
_smb_fname,
&symlink_err);
if (NT_STATUS_IS_OK(status) && S_ISLNK((*_smb_fname)->st.st_ex_mode)) {
/*
* lcomp is a symlink
*/
if (ucf_flags & UCF_LCOMP_LNK_OK) {
TALLOC_FREE(symlink_err);
return NT_STATUS_OK;
}
close_file_free(NULL, _dirfsp, ERROR_CLOSE);
status = NT_STATUS_STOPPED_ON_SYMLINK;
}
if (!NT_STATUS_EQUAL(status, NT_STATUS_STOPPED_ON_SYMLINK)) {
return status;
}