mirror of
https://github.com/samba-team/samba.git
synced 2024-12-27 03:21:53 +03:00
r8247: remove the free of fullname in nbtname.c for now.
Metze, the ndr_token_store() code is storing temporary pointers into
this string in the token list, which means we are referring to freed
memory when we scan the token list. A better key might be a pointer
into the ndr buffer?
(This used to be commit 6a4e8cc991
)
This commit is contained in:
parent
5c87688051
commit
bde98850be
@ -343,8 +343,12 @@ NTSTATUS ndr_push_nbt_name(struct ndr_push *ndr, int ndr_flags, const struct nbt
|
||||
}
|
||||
|
||||
status = ndr_push_nbt_string(ndr, ndr_flags, fullname);
|
||||
#if 0
|
||||
/* this free conflicts with the use of pointers into strings
|
||||
in the ndr_token_store() calls above. Metze, can you look
|
||||
at this? */
|
||||
talloc_free(fullname);
|
||||
|
||||
#endif
|
||||
return status;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user