1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00

source/rpc_parse/parse_prs.c ZERO_STRUCTP(ps) not needed as it is done

in prs_init now

testsuite/printing/psec.c	cannot do a prs_mem_free() when tdb_prs_fetch fails
				as the prs structure has not been initialized
(This used to be commit a363e5d8c549861329506bd87c11d82ace5520e5)
This commit is contained in:
Herb Lewis 2004-01-14 22:53:50 +00:00
parent 2624dd0313
commit be1b3604ef
2 changed files with 5 additions and 3 deletions

View File

@ -1307,7 +1307,6 @@ int tdb_prs_fetch(TDB_CONTEXT *tdb, char *keystr, prs_struct *ps, TALLOC_CTX *me
if (!dbuf.dptr)
return -1;
ZERO_STRUCTP(ps);
prs_init(ps, 0, mem_ctx, UNMARSHALL);
prs_give_memory(ps, dbuf.dptr, dbuf.dsize, True);

View File

@ -195,8 +195,11 @@ int psec_getsec(char *printer)
if (tdb_prs_fetch(tdb, keystr, &ps, mem_ctx) != 0) {
printf("error fetching descriptor for printer %s\n",
printer);
result = 1;
goto done;
/* cannot do a prs_mem_free() when tdb_prs_fetch fails */
/* as the prs structure has not been initialized */
tdb_close(tdb);
talloc_destroy(mem_ctx);
return 1;
}
/* Unpack into security descriptor buffer */