sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-03 13:47:25 +03:00
Code

vfs_ceph_new: use low-level APIs for lchown

Browse Source 
Use libcephfs' low-level API ceph_ll_setattr to implement VFS lchown_fn
hook. Use to standard pattern of iget/iput to allow operation by Inode
reference.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15686

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
This commit is contained in:
Shachar Sharon 2024-06-17 16:59:05 +03:00 committed by Günther Deschner
parent 47224fbdeb
commit beb21324c9
1 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
source3/modules/vfs_ceph_new.c
View File

@ -447,6 +447,28 @@ static int vfs_ceph_ll_getattr(const struct vfs_handle_struct *handle,
return ret; return ret;
} }
static int vfs_ceph_ll_chown(struct vfs_handle_struct *handle,
const struct vfs_ceph_iref *iref,
uid_t uid,
gid_t gid)
{
struct ceph_statx stx = {.stx_uid = uid, .stx_gid = gid};
struct UserPerm *uperm = NULL;
int ret = -1;
uperm = vfs_ceph_userperm_new(handle);
if (uperm == NULL) {
return -ENOMEM;
}
ret = ceph_ll_setattr(handle->data,
iref->inode,
&stx,
CEPH_STATX_UID | CEPH_STATX_GID,
uperm);
vfs_ceph_userperm_del(uperm);
return ret;
}
/* Ceph Inode-refernce get/put wrappers */ /* Ceph Inode-refernce get/put wrappers */
static int vfs_ceph_iget(const struct vfs_handle_struct *handle, static int vfs_ceph_iget(const struct vfs_handle_struct *handle,
uint64_t ino, uint64_t ino,
@ -1401,12 +1423,22 @@ static int vfs_ceph_lchown(struct vfs_handle_struct *handle,
gid_t gid) gid_t gid)
{ {
int result; int result;
struct vfs_ceph_iref iref = {0};
DBG_DEBUG("[CEPH] lchown(%p, %s, %d, %d)\n", DBG_DEBUG("[CEPH] lchown(%p, %s, %d, %d)\n",
handle, handle,
smb_fname->base_name, smb_fname->base_name,
uid, uid,
gid); gid);
result = ceph_lchown(handle->data, smb_fname->base_name, uid, gid);
result = vfs_ceph_igetl(handle, smb_fname, &iref);
if (result != 0) {
goto out;
}
result = vfs_ceph_ll_chown(handle, &iref, uid, gid);
vfs_ceph_iput(handle, &iref);
out:
DBG_DEBUG("[CEPH] lchown(...) = %d\n", result); DBG_DEBUG("[CEPH] lchown(...) = %d\n", result);
return status_code(result); return status_code(result);
} }