sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-20 22:50:26 +03:00
Code

vfs_fruit: remove check for number of xattrs from ad_convert_xattr

Browse Source 
Turns out that there exist AppleDouble files with an extended FinderInfo
entry that includes the xattr marshall buffer, but the count of xattrs
in the buffer is just zero.

We do want to discard this extended FinderInfo entry and convert it to a
simple fixed size FinderInfo entry, so remove the check.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5d565f636fcf49fc1bbbfbc24ef730d2f7cc2cf0)

Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Thu Nov  1 18:58:13 CET 2018 on sn-devel-144
This commit is contained in:
Ralph Boehme 2018-10-19 12:15:42 +02:00 committed by Karolin Seeger
parent ec065a8ac2
commit bfa9fd3162
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source3/modules/vfs_fruit.c
View File

@ -1014,10 +1014,6 @@ static bool ad_convert_xattr(struct adouble *ad,
return true;
}
if (ad->adx_header.adx_num_attrs == 0) {
return true;
}
if (string_replace_cmaps == NULL) {
const char **mappings = NULL;