sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code

r16270: Fix Klocwork #706 - ensure sscanf has correct format

Browse Source 
specifier.
Jeremy.
(This used to be commit dc53d35b0a)
This commit is contained in:
Jeremy Allison 2006-06-15 21:46:15 +00:00 committed by Gerald (Jerry) Carter
parent 9e7377e81f
commit c2528679d8
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source3/utils/net_idmap.c
View File

@ -193,7 +193,7 @@ static int net_idmap_restore(int argc, const char **argv)
}
while (!feof(stdin)) {
fstring line, sid_string;
fstring line, sid_string, fmt_string;
int len;
unid_t id;
int type = ID_EMPTY;
@ -208,14 +208,15 @@ static int net_idmap_restore(int argc, const char **argv)
line[len-1] = '\0';
/* Yuck - this is broken for sizeof(gid_t) != sizeof(int) */
if (sscanf(line, "GID %d %s", &id.gid, sid_string) == 2) {
snprintf(fmt_string, sizeof(fmt_string), "GID %%d %%%us", FSTRING_LEN);
if (sscanf(line, fmt_string, &id.gid, sid_string) == 2) {
type = ID_GROUPID;
}
/* Yuck - this is broken for sizeof(uid_t) != sizeof(int) */
if (sscanf(line, "UID %d %s", &id.uid, sid_string) == 2) {
snprintf(fmt_string, sizeof(fmt_string), "UID %%d %%%us", FSTRING_LEN);
if (sscanf(line, fmt_string, &id.uid, sid_string) == 2) {
type = ID_USERID;
}