sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

ndr: Fix NDR push function for dnsp_string

Browse Source 
Push the actual length of the string not including null-termination.
This commit is contained in:
Amitay Isaacs 2012-02-28 13:58:48 +11:00
parent ad1ef79486
commit c46763419a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
librpc/ndr/ndr_dnsp.c
View File

@ -160,14 +160,13 @@ _PUBLIC_ enum ndr_err_code ndr_pull_dnsp_string(struct ndr_pull *ndr, int ndr_fl
enum ndr_err_code ndr_push_dnsp_string(struct ndr_push *ndr, int ndr_flags, const char *string) enum ndr_err_code ndr_push_dnsp_string(struct ndr_push *ndr, int ndr_flags, const char *string)
{ {
int total_len; int total_len;
total_len = strlen(string) + 1; total_len = strlen(string);
if (total_len > 255) { if (total_len > 255) {
return ndr_push_error(ndr, NDR_ERR_BUFSIZE, return ndr_push_error(ndr, NDR_ERR_BUFSIZE,
"dns_name of length %d larger than 255", total_len); "dns_name of length %d larger than 255", total_len);
} }
NDR_CHECK(ndr_push_uint8(ndr, ndr_flags, (uint8_t)total_len)); NDR_CHECK(ndr_push_uint8(ndr, ndr_flags, (uint8_t)total_len));
NDR_CHECK(ndr_push_bytes(ndr, (const uint8_t *)string, total_len - 1)); NDR_CHECK(ndr_push_bytes(ndr, (const uint8_t *)string, total_len));
NDR_PUSH_ALIGN(ndr, 1);
return NDR_ERR_SUCCESS; return NDR_ERR_SUCCESS;
} }