sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

s3: tests: Add new test_stream_dir_rename.sh test.

Browse Source 
Shows we are leaking an fsp/fd if we request a non-existent stream on a file.
This then causes rename of a directory containing the file to be denied, as
it thinks we have an existing open file below it.

Add knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15314

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Jeremy Allison 2023-02-28 11:18:10 -08:00 committed by Ralph Boehme
parent 5a3db5105b
commit c54bec26ad
3 changed files with 77 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/stream_rename Normal file
View File

@ -0,0 +1 @@
^samba3.blackbox.stream_dir_rename.stream_rename\(fileserver\)

72
source3/script/tests/test_stream_dir_rename.sh Executable file
View File

@ -0,0 +1,72 @@
#!/bin/sh
#
# Test a stream can rename a directory once an invalid stream path below it was requested.
# BUG: https://bugzilla.samba.org/show_bug.cgi?id=15314
if [ $# -lt 5 ]; then
cat <<EOF
Usage: test_stream_dir_rename.sh SERVER USERNAME PASSWORD PREFIX SMBCLIENT
EOF
exit 1
fi
SERVER="${1}"
USERNAME="${2}"
PASSWORD="${3}"
PREFIX="${4}"
SMBCLIENT="${5}"
SMBCLIENT="$VALGRIND ${SMBCLIENT}"
shift 5
incdir=$(dirname $0)/../../../testprogs/blackbox
. $incdir/subunit.sh
failed=0
# Do not let deprecated option warnings muck this up
SAMBA_DEPRECATED_SUPPRESS=1
export SAMBA_DEPRECATED_SUPPRESS
test_stream_xattr_rename()
{
tmpfile=$PREFIX/smbclient_interactive_prompt_commands
#
# Test against streams_xattr_nostrict
#
cat >$tmpfile <<EOF
deltree stream_xattr_test
deltree stream_xattr_test1
mkdir stream_xattr_test
put ${PREFIX}/smbclient_interactive_prompt_commands stream_xattr_test/file.txt
get stream_xattr_test/file.txt:abcf
rename stream_xattr_test stream_xattr_test1
deltree stream_xattr_test
deltree stream_xattr_test1
quit
EOF
cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT "$@" -U$USERNAME%$PASSWORD //$SERVER/streams_xattr_nostrict < $tmpfile 2>&1'
eval echo "$cmd"
out=$(eval $cmd)
ret=$?
rm -f $tmpfile
if [ $ret -ne 0 ]; then
echo "$out"
echo "failed rename on xattr stream test to test1 with error $ret"
return 1
fi
echo "$out" | grep "NT_STATUS_ACCESS_DENIED"
ret=$?
if [ $ret -eq 0 ]; then
echo "$out"
echo "failed rename on xattr stream with NT_STATUS_ACCESS_DENIED"
return 1
fi
}
testit "stream_rename" \
test_stream_xattr_rename ||
failed=$((failed + 1))
testok "$0" "$failed"

4
source3/selftest/tests.py
View File

@ -778,6 +778,10 @@ for env in ["fileserver"]:
[os.path.join(samba3srcdir, "script/tests/test_veto_files.sh"),
'$SERVER', '$SERVER_IP', '$USERNAME', '$PASSWORD', '$LOCAL_PATH/veto', smbclient3])
plantestsuite("samba3.blackbox.stream_dir_rename", env,
[os.path.join(samba3srcdir, "script/tests/test_stream_dir_rename.sh"),
'$SERVER', '$USERNAME', '$PASSWORD', '$PREFIX', smbclient3])
#
# tar command tests
#