sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

auth: Remove early return from make_user_info_dc_pac()

Browse Source 
'rg' is never NULL, so this codepath is never taken. But if it were, we
would return early and entirely neglect filling in the UPN_DNS_INFO from
the 'pac_upn_dns_info' parameter. So remove the early return.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2022-11-07 19:37:12 +13:00 committed by Andrew Bartlett
parent 94cda2dfd5
commit c7b76764dc
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
auth/auth_sam_reply.c
View File

@ -605,12 +605,7 @@ NTSTATUS make_user_info_dc_pac(TALLOC_CTX *mem_ctx,
rg = &pac_logon_info->resource_groups;
}
if (rg == NULL) {
*_user_info_dc = user_info_dc;
return NT_STATUS_OK;
}
if (rg->groups.count > 0) {
if (rg != NULL && rg->groups.count > 0) {
/* The IDL layer would be a better place to check this, but to
* guard the integer addition below, we double-check */
if (rg->groups.count > 65535) {