1
0
mirror of https://github.com/samba-team/samba.git synced 2025-08-04 08:22:08 +03:00

smbd: some write time fixes

- only the first non truncating write causes
  the write time update with 2 seconds delay.
  It's not enough to check for an existing update event
  as it will be NULL after the event was triggered.

- SMBwrite truncates always update the write time
  unless the sticky write time is set.

- SMBwrite truncates don't trigger a write time update on close.

metze
(This used to be commit 3d17089b6d)
This commit is contained in:
Stefan Metzmacher
2008-09-08 15:12:24 +02:00
parent ae02be5287
commit c9fb96146c
2 changed files with 8 additions and 8 deletions

View File

@ -202,12 +202,13 @@ void trigger_write_time_update(struct files_struct *fsp)
return;
}
if (fsp->update_write_time_event) {
if (fsp->update_write_time_triggered) {
/*
* No point - an event is already scheduled.
*/
return;
}
fsp->update_write_time_triggered = true;
delay = lp_parm_int(SNUM(fsp->conn),
"smbd", "writetimeupdatedelay",
@ -232,14 +233,12 @@ void trigger_write_time_update_immediate(struct files_struct *fsp)
return;
}
if (fsp->update_write_time_event) {
/*
* No point - an event is already scheduled.
*/
return;
}
TALLOC_FREE(fsp->update_write_time_event);
DEBUG(5, ("Update write time immediate on %s\n", fsp->fsp_name));
fsp->update_write_time_on_close = true;
fsp->update_write_time_triggered = true;
fsp->update_write_time_on_close = false;
update_write_time(fsp);
}