sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-16 00:23:52 +03:00
Code Activity

pytest:sid_strings: add explicit S-1-* sid tests

Browse Source 
We are mostly testing edge cases around the handling of numeric
limits.

These tests are based on ground truth established by running them
against Windows.

Many fail against Samba, because the defaulSecurityDescriptor
attribute is not validated at the time it is set while on Windows it
is.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall
2023-04-05 15:39:24 +12:00
committed by Andrew Bartlett
parent 4380b4694f
commit cb356a8d90
2 changed files with 61 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
python/samba/tests/sid_strings.py
View File

@@ -199,7 +199,7 @@ cn: {object_name}
@DynamicTestCase
class SidStringTests(SidStringBase):
"""Testing two letter aliases."""
cases = {
'AA': 'S-1-5-32-579',
'AC': 'S-1-15-2-1',
@@ -276,6 +276,50 @@ class SidStringTests(SidStringBase):
}
@DynamicTestCase
class SidStringsThatStartWithS(SidStringBase):
"""Testing normal or normal-adjacent SIDs"""
cases = {
# testing explicit string to string round trips.
'S-1-5-32-579': 'S-1-5-32-579',
'S-1-5-0x20-579': 'S-1-5-32-579', # hex
'S-1-0x05-32-579': 'S-1-5-32-579',
'S-1-5-040-579': 'S-1-5-40-579', # no octal
'S-1-0x50000000-32-579': 'S-1-1342177280-32-579',
'S-1-0x500000000-32-579': 'S-1-0x500000000-32-579',
'S-1-21474836480-32-579': 'S-1-0x500000000-32-579', # >32 bit is hex
f'S-1-5-{(1 << 32) - 1}-579': 'S-1-5-4294967295-579',
f'S-1-{(1 << 48) - 1}-579': 'S-1-0xffffffffffff-579',
f'S-1-{(1 << 48)}-579': ldb.ERR_UNWILLING_TO_PERFORM,
'S-1-99999999999999999999999999999999999999-32-11111111111': ldb.ERR_UNWILLING_TO_PERFORM,
'S-1-5-0-579': 'S-1-5-0-579',
'S-1-0-0-579': 'S-1-0-0-579',
'S-1-0x5-0x20-0x243': 'S-1-5-32-579',
'S-1-5-32--579': ldb.ERR_UNWILLING_TO_PERFORM,
'S-1-5-32- 579': ldb.ERR_UNWILLING_TO_PERFORM,
'S-1-5-32 -579': ldb.ERR_UNWILLING_TO_PERFORM,
'S-1-5-3 2-579': ldb.ERR_UNWILLING_TO_PERFORM,
' S-1-1-1-1-1-1-1': ldb.ERR_UNWILLING_TO_PERFORM,
# go to lower case in hex.
'S-1-0xABcDef123-0xABCDef-579': 'S-1-0xabcdef123-11259375-579',
'S-1-1-1-1-1-1-1': 'S-1-1-1-1-1-1-1',
's-1-5-32-579': 'S-1-5-32-579',
'S-01-5-32-579': 'S-1-5-32-579',
'S-000000001-5-32-579': 'S-1-5-32-579',
# some strings from https://bugzilla.samba.org/show_bug.cgi?id=14213
'S-1-0': ldb.ERR_UNWILLING_TO_PERFORM,
'S-1-22': ldb.ERR_UNWILLING_TO_PERFORM,
'S-1-22-1': 'S-1-22-1',
'S-1-22-1-0': 'S-1-22-1-0',
'S-1-3-0': 'S-1-3-0',
'S-1-3-99': 'S-1-3-99',
'S-01-05-020-0243': 'S-1-5-20-243',
'S-000000000001-5-20-243': 'S-1-5-20-243',
'S-1-000000000000000005-20-243': 'S-1-5-20-243',
'S-1-5-20-00000000000243': 'S-1-5-20-243',
}
if __name__ == '__main__':
global_asn1_print = False
global_hexdump = False