From cbae31c7946fc13c3a00bc81a102e90fdec00018 Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Tue, 27 Oct 2015 12:06:25 +1100 Subject: [PATCH] build: --picky-developer implies --enable-developer Have --picky-developer enable --enable-developer too, instead of requiring both options to be specified. This makes it obey the principle of least surprise. Signed-off-by: Martin Schwenke Reviewed-by: Andrew Bartlett Autobuild-User(master): Martin Schwenke Autobuild-Date(master): Tue Oct 27 07:19:33 CET 2015 on sn-devel-104 --- buildtools/wafsamba/wscript | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript index f3e019c0b73..5bce17d0cb0 100755 --- a/buildtools/wafsamba/wscript +++ b/buildtools/wafsamba/wscript @@ -96,9 +96,13 @@ def set_options(opt): gr.add_option('--enable-developer', help=("Turn on developer warnings and debugging"), action="store_true", dest='developer', default=False) + def picky_developer_callback(option, opt_str, value, parser): + parser.values.developer = True + parser.values.picky_developer = True gr.add_option('--picky-developer', help=("Treat all warnings as errors (enable -Werror)"), - action="store_true", dest='picky_developer', default=False) + action="callback", callback=picky_developer_callback, + dest='picky_developer', default=False) gr.add_option('--fatal-errors', help=("Stop compilation on first error (enable -Wfatal-errors)"), action="store_true", dest='fatal_errors', default=False)