sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

dcesrv_core: return NAK_REASON_PROTOCOL_VERSION_NOT_SUPPORTED for binds without contexts

Browse Source 
This is the error Windows 2022 (and 2025 preview) return.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 8e6696b2ac6990f3d6bac804c9a0f1a2b8f0ada0)
This commit is contained in:
Stefan Metzmacher 2024-09-24 09:05:15 +02:00 committed by Jule Anger
parent 346dab391d
commit cbcd11f2fb
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
librpc/rpc/dcesrv_core.c
View File

@ -1141,7 +1141,8 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
} }
if (call->pkt.u.bind.num_contexts < 1) { if (call->pkt.u.bind.num_contexts < 1) {
return dcesrv_bind_nak(call, 0); return dcesrv_bind_nak(call,
DCERPC_BIND_NAK_REASON_PROTOCOL_VERSION_NOT_SUPPORTED);
} }
ack_ctx_list = talloc_zero_array(call, struct dcerpc_ack_ctx, ack_ctx_list = talloc_zero_array(call, struct dcerpc_ack_ctx,

2
source4/selftest/tests.py
View File

@ -1371,14 +1371,12 @@ planoldpythontestsuite("ad_dc", "samba.tests.dcerpc.dnsserver", extra_args=['-U"
planoldpythontestsuite("chgdcpass", "samba.tests.dcerpc.raw_protocol", planoldpythontestsuite("chgdcpass", "samba.tests.dcerpc.raw_protocol",
environ={"MAX_NUM_AUTH": "8", environ={"MAX_NUM_AUTH": "8",
"ALLOW_BIND_AUTH_PAD": "1", "ALLOW_BIND_AUTH_PAD": "1",
"LEGACY_BIND_NACK_NO_REASON": "1",
"USERNAME": "$DC_USERNAME", "USERNAME": "$DC_USERNAME",
"PASSWORD": "$DC_PASSWORD"}) "PASSWORD": "$DC_PASSWORD"})
planoldpythontestsuite("ad_member", "samba.tests.dcerpc.raw_protocol", planoldpythontestsuite("ad_member", "samba.tests.dcerpc.raw_protocol",
environ={"MAX_NUM_AUTH": "8", environ={"MAX_NUM_AUTH": "8",
"ALLOW_BIND_AUTH_PAD": "1", "ALLOW_BIND_AUTH_PAD": "1",
"AUTH_LEVEL_CONNECT_LSA": "1", "AUTH_LEVEL_CONNECT_LSA": "1",
"LEGACY_BIND_NACK_NO_REASON": "1",
"USERNAME": "$DC_USERNAME", "USERNAME": "$DC_USERNAME",
"PASSWORD": "$DC_PASSWORD"}) "PASSWORD": "$DC_PASSWORD"})