sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-27 07:42:04 +03:00
Code Activity

schema.py: avoid inefficient string concatenations

Browse Source 
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Björn Jacke
2019-08-25 23:06:19 +02:00
committed by Bjoern Jacke
parent d2d8ebcca1
commit cf51f73e02
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
python/samba/schema.py
View File

@ -111,9 +111,7 @@ class Schema(object):
setup_path('ad-schema/%s' % Schema.base_schemas[base_schema][1]))
if files is not None:
for file in files:
data = get_string(open(file, 'rb').read())
self.schema_data += data
self.schema_data = "".join(get_string(open(file, 'rb').read()) for file in files)
self.schema_data = substitute_var(self.schema_data,
{"SCHEMADN": schemadn})
@ -135,8 +133,7 @@ class Schema(object):
self.prefixmap_data = open(setup_path("prefixMap.txt"), 'rb').read()
if additional_prefixmap is not None:
for map in additional_prefixmap:
self.prefixmap_data += "%s\n" % map
self.prefixmap_data += "".join("%s\n" % map for map in additional_prefixmap)
self.prefixmap_data = b64encode(self.prefixmap_data).decode('utf8')