From cfb81b0c3138d6cb89cd88ce494c60acd7c2cc7f Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 19 Jun 2024 11:50:26 +0200 Subject: [PATCH] packaging: Add missing quotes in smbprint Found by Covscan. "Error: SHELLCHECK_WARNING (CWE-569): /usr/bin/smbprint:49:21: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. 47| # Concat this with /.config to get the config file. 48| # 49|-> eval acct_file=\${$#} 50| spool_dir=$(dirname $acct_file) 51| config_file=$spool_dir/.config" Signed-off-by: Andreas Schneider Reviewed-by: Signed-off-by: Martin Schwenke Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Jun 24 07:14:54 UTC 2024 on atb-devel-224 --- packaging/printing/smbprint | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/printing/smbprint b/packaging/printing/smbprint index a21385aa25c..5439207c041 100644 --- a/packaging/printing/smbprint +++ b/packaging/printing/smbprint @@ -46,7 +46,7 @@ # Extract the directory name from the file name. # Concat this with /.config to get the config file. # -eval acct_file=\${$#} +eval acct_file="\${$#}" spool_dir=$(dirname $acct_file) config_file=$spool_dir/.config