sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

s3:vfs:syncops add option to disable metasync per share

Browse Source 
introduce an option to disable the metadata sync
in case the filesystem handles this correctly the sync can be
skipped, but synchronization of the data that was written can still
be configured (in opposition to the disable flag disabling all
sync operations)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Feb 18 17:31:59 CET 2011 on sn-devel-104
This commit is contained in:
Christian Ambach 2011-02-18 13:03:52 +01:00 committed by Volker Lendecke
parent 927792b212
commit d05aa90384
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source3/modules/vfs_syncops.c
View File

@ -2,6 +2,7 @@
* ensure meta data operations are performed synchronously
*
* Copyright (C) Andrew Tridgell 2007
* Copyright (C) Christian Ambach, 2010-2011
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -37,13 +38,19 @@
syncops:onclose = no
that can be set either globally or per share.
you can also disable the module completely for a service with
On certain filesystems that only require the last data written to be
fsync()'ed, you can disable the metadata synchronization of this module with
syncops:onmeta = no
This option can be set either globally or per share.
you can also disable the module completely for a share with
syncops:disable = true
*/
struct syncops_config_data {
bool onclose;
bool onmeta;
bool disable;
};
@ -142,7 +149,7 @@ static int syncops_rename(vfs_handle_struct *handle,
return -1);
ret = SMB_VFS_NEXT_RENAME(handle, smb_fname_src, smb_fname_dst);
if (ret == 0 && !config->disable) {
if (ret == 0 && config->onmeta && !config->disable) {
syncops_two_names(smb_fname_src->base_name,
smb_fname_dst->base_name);
}
@ -158,7 +165,7 @@ static int syncops_rename(vfs_handle_struct *handle,
return -1); \
ret = SMB_VFS_NEXT_ ## op args; \
if (ret == 0 \
&& !config->disable \
&& config->onmeta && !config->disable \
&& fname) syncops_name(fname); \
return ret; \
} while (0)
@ -171,7 +178,7 @@ static int syncops_rename(vfs_handle_struct *handle,
return -1); \
ret = SMB_VFS_NEXT_ ## op args; \
if (ret == 0 \
&& !config->disable \
&& config->onmeta && !config->disable \
&& fname) syncops_smb_fname(fname); \
return ret; \
} while (0)
@ -255,6 +262,9 @@ int syncops_connect(struct vfs_handle_struct *handle, const char *service,
config->onclose = lp_parm_bool(SNUM(handle->conn), "syncops",
"onclose", true);
config->onmeta = lp_parm_bool(SNUM(handle->conn), "syncops",
"onmeta", true);
config->disable = lp_parm_bool(SNUM(handle->conn), "syncops",
"disable", false);