sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-26 21:57:41 +03:00
Code

s4:rpc_server: Add transaction for dcesrv_samr_SetUserInfo()

Browse Source 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 1aa403517ffc0d43df72ddc9fa2ce86ab5c33873)
This commit is contained in:
Andreas Schneider 2022-07-26 11:04:29 +02:00 committed by Jule Anger
parent f7f1106b2e
commit d0cd367da4
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source4/rpc_server/samr/dcesrv_samr.c
View File

@ -3647,6 +3647,13 @@ static NTSTATUS dcesrv_samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALL
return NT_STATUS_NO_MEMORY;
}
ret = ldb_transaction_start(sam_ctx);
if (ret != LDB_SUCCESS) {
DBG_ERR("Failed to start a transaction: %s\n",
ldb_errstring(sam_ctx));
return NT_STATUS_LOCK_NOT_GRANTED;
}
switch (r->in.level) {
case 2:
SET_STRING(msg, info2.comment, "comment");
@ -4092,8 +4099,21 @@ static NTSTATUS dcesrv_samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALL
}
}
ret = ldb_transaction_commit(sam_ctx);
if (ret != LDB_SUCCESS) {
DBG_ERR("Failed to commit transaction modifying account record "
"%s: %s\n",
ldb_dn_get_linearized(msg->dn),
ldb_errstring(sam_ctx));
return NT_STATUS_INTERNAL_DB_CORRUPTION;
}
status = NT_STATUS_OK;
done:
if (!NT_STATUS_IS_OK(status)) {
ldb_transaction_cancel(sam_ctx);
}
return status;
}