sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-17 04:23:50 +03:00
Code Activity

tests/auth_log: Properly expect authentication failures

Browse Source 
These authentications are actually failing (due to RESPONSE_TOO_BIG
errors), but our authentication logging infrastructure hides this.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton
2023-06-14 15:28:39 +12:00
committed by Andrew Bartlett
parent 11671a743f
commit d1fcecd121
2 changed files with 37 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
python/samba/tests/auth_log.py
View File

@@ -176,13 +176,14 @@ class AuthLogTests(samba.tests.auth_log_base.AuthLogTestBase):
# returning message too big,
msg = messages[0]
self.assertEqual("Authentication", msg["type"])
self.assertEqual("NT_STATUS_OK", msg["Authentication"]["status"])
self.assertEqual("NT_STATUS_PROTOCOL_UNREACHABLE", # RESPONSE_TOO_BIG
msg["Authentication"]["status"])
self.assertEqual("Kerberos KDC",
msg["Authentication"]["serviceDescription"])
self.assertEqual(authTypes[1],
msg["Authentication"]["authDescription"])
self.assertEqual(
EVT_ID_SUCCESSFUL_LOGON, msg["Authentication"]["eventId"])
EVT_ID_UNSUCCESSFUL_LOGON, msg["Authentication"]["eventId"])
self.assertEqual(
EVT_LOGON_NETWORK, msg["Authentication"]["logonType"])
@@ -372,13 +373,14 @@ class AuthLogTests(samba.tests.auth_log_base.AuthLogTestBase):
# Check the second message it should be an Authentication
msg = messages[1]
self.assertEqual("Authentication", msg["type"])
self.assertEqual("NT_STATUS_OK", msg["Authentication"]["status"])
self.assertEqual("NT_STATUS_PROTOCOL_UNREACHABLE", # RESPONSE_TOO_BIG
msg["Authentication"]["status"])
self.assertEqual("Kerberos KDC",
msg["Authentication"]["serviceDescription"])
self.assertEqual(authTypes[2],
msg["Authentication"]["authDescription"])
self.assertEqual(
EVT_ID_SUCCESSFUL_LOGON, msg["Authentication"]["eventId"])
EVT_ID_UNSUCCESSFUL_LOGON, msg["Authentication"]["eventId"])
self.assertEqual(
EVT_LOGON_NETWORK, msg["Authentication"]["logonType"])
@@ -491,14 +493,15 @@ class AuthLogTests(samba.tests.auth_log_base.AuthLogTestBase):
# Check the first message it should be an Authentication
msg = messages[0]
self.assertEqual("Authentication", msg["type"])
self.assertEqual("NT_STATUS_OK", msg["Authentication"]["status"])
self.assertEqual("NT_STATUS_PROTOCOL_UNREACHABLE", # RESPONSE_TOO_BIG
msg["Authentication"]["status"])
self.assertEqual("Kerberos KDC",
msg["Authentication"]["serviceDescription"])
self.assertEqual("ENC-TS Pre-authentication",
msg["Authentication"]["authDescription"])
self.assertTrue(msg["Authentication"]["duration"] > 0)
self.assertEqual(
EVT_ID_SUCCESSFUL_LOGON, msg["Authentication"]["eventId"])
EVT_ID_UNSUCCESSFUL_LOGON, msg["Authentication"]["eventId"])
self.assertEqual(
EVT_LOGON_NETWORK, msg["Authentication"]["logonType"])
@@ -735,12 +738,13 @@ class AuthLogTests(samba.tests.auth_log_base.AuthLogTestBase):
# Check the first message it should be an Authentication
msg = messages[0]
self.assertEqual("Authentication", msg["type"])
self.assertEqual("NT_STATUS_OK", msg["Authentication"]["status"])
self.assertEqual("NT_STATUS_PROTOCOL_UNREACHABLE", # RESPONSE_TOO_BIG
msg["Authentication"]["status"])
self.assertEqual("Kerberos KDC",
msg["Authentication"]["serviceDescription"])
self.assertEqual("ENC-TS Pre-authentication",
msg["Authentication"]["authDescription"])
self.assertEqual(EVT_ID_SUCCESSFUL_LOGON,
self.assertEqual(EVT_ID_UNSUCCESSFUL_LOGON,
msg["Authentication"]["eventId"])
self.assertEqual(EVT_LOGON_NETWORK,
msg["Authentication"]["logonType"])