sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-09 08:58:35 +03:00
Code

lib:util: Move open() of /dev/null into the if-clause

Browse Source 
"Error: RESOURCE_LEAK (CWE-772):
samba-4.20.0rc2/lib/util/close_low_fd.c:40: open_fn: Returning handle opened by ""open"". [Note: The source code implementation of the function has been overridden by a user model.]
samba-4.20.0rc2/lib/util/close_low_fd.c:40: var_assign: Assigning: ""dev_null"" = handle returned from ""open(""/dev/null"", 2, 0)"".
samba-4.20.0rc2/lib/util/close_low_fd.c:52: overwrite_var: Overwriting handle ""dev_null"" in ""dev_null = open(""/dev/null"", 2, 0)"" leaks the handle.
   50|   	}
   51|
   52|-> 	dev_null = open(""/dev/null"", O_RDWR, 0);
   53|   	if (dev_null == -1) {
   54|   		dev_null = open(""/dev/null"", O_WRONLY, 0);"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
This commit is contained in:
Andreas Schneider 2024-07-08 10:14:39 +02:00 committed by Günther Deschner
parent ddadbddb40
commit d21b8e057c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/util/close_low_fd.c
View File

@ -47,9 +47,10 @@ _PUBLIC_ int close_low_fd(int fd)
if (ret != 0) {
return errno;
}
dev_null = open("/dev/null", O_RDWR, 0);
}
dev_null = open("/dev/null", O_RDWR, 0);
if (dev_null == -1) {
dev_null = open("/dev/null", O_WRONLY, 0);
}