sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code

s3-auth Remove pointless destructor in make_server_info

Browse Source 
All the callers allocate ->info3 as a talloc child already.

As regardes the TALLOC_ZERO(), I added this originally out of parinoia
many years ago.  We do not consistantly zero session keys in memory,
and for NTLMv2 and Kerberos they are random for each sesssion, so
breaking into smbd far enough to read an old session key isn't a
particularly interesting attack, compared with (say) reading the
keytab or the password database.  (NTLM and LM session keys are fixed
derivitives of the passwords however).

Andrew Bartlett
This commit is contained in:
Andrew Bartlett 2011-07-19 16:05:32 +10:00
parent 15123d96ff
commit d2a661a531
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source3/auth/server_info.c
View File

@ -29,14 +29,6 @@
#undef DBGC_CLASS
#define DBGC_CLASS DBGC_AUTH
/* FIXME: do we really still need this ? */
static int server_info_dtor(struct auth_serversupplied_info *server_info)
{
TALLOC_FREE(server_info->info3);
ZERO_STRUCTP(server_info);
return 0;
}
/***************************************************************************
Make a server_info struct. Free with TALLOC_FREE().
***************************************************************************/
@ -51,8 +43,6 @@ struct auth_serversupplied_info *make_server_info(TALLOC_CTX *mem_ctx)
return NULL;
}
talloc_set_destructor(result, server_info_dtor);
/* Initialise the uid and gid values to something non-zero
which may save us from giving away root access if there
is a bug in allocating these fields. */