sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

selftest: Run samba3.srvsvc tests covering more of the srvsvc server

Browse Source 
Found by LCOV.

Some of the failures should be fixed by setting "restrict anonymous = 2"
as requested by bug 12775

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Andrew Bartlett 2019-05-23 12:21:46 +12:00
parent 773e476203
commit d2f54775d3
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
selftest/knownfail.d/srvsvc Normal file
View File

@ -0,0 +1,24 @@
# Except where noted these are missing RPCs with just give a simple
# fault (mapped to NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareGetInfo\(ad_member\)
# Level 501 is supported in the s3 srvsrv server
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnum\(ad_member\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetTransportEnum\(ad_member\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnumAll\(ad_member\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevQEnum\(ad_member\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevEnum\(ad_member\)
^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareGetInfo\(ad_member\)
^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnum\(ad_member\)
^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnumAll\(ad_member\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareGetInfo\(ad_dc\)
# Level 501 is supported in the s3 srvsrv server
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnum\(ad_dc\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetTransportEnum\(ad_dc\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnumAll\(ad_dc\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevQEnum\(ad_dc\)
^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevEnum\(ad_dc\)
# These should be fixed by setting 'restrict anonymous = 2' by default
# per https://bugzilla.samba.org/show_bug.cgi?id=12775
^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareGetInfo\(ad_dc\)
^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnum\(ad_dc\)
^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnumAll\(ad_dc\)

5
source3/selftest/tests.py
View File

@ -464,7 +464,7 @@ rpc = ["rpc.authcontext", "rpc.samba3.bind", "rpc.samba3.srvsvc", "rpc.samba3.sh
"rpc.samr.priv", "rpc.samr.passwords.validate",
"rpc.netlogon.admin",
"rpc.schannel", "rpc.schannel2", "rpc.bench-schannel1", "rpc.schannel_anon_setpw", "rpc.join", "rpc.bind",
"rpc.initshutdown", "rpc.wkssvc"]
"rpc.initshutdown", "rpc.wkssvc", "rpc.srvsvc"]
local = ["local.nss"]
@ -671,6 +671,9 @@ for t in tests:
plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$USERNAME%$PASSWORD')
elif t == "rpc.wkssvc":
plansmbtorture4testsuite(t, "ad_member", '//$SERVER/tmp -U$DC_USERNAME%$DC_PASSWORD')
elif t == "rpc.srvsvc":
plansmbtorture4testsuite(t, "ad_member", '//$SERVER/tmp -U$DC_USERNAME%$DC_PASSWORD')
plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$DC_USERNAME%$DC_PASSWORD')
else:
plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD')
plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$USERNAME%$PASSWORD')