sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-14 01:57:53 +03:00
Code

smbd: remove comments about deprecated 'write cache size'

Browse Source 
The option 'write cache size' was removed since samba-4.12 version:
https://wiki.samba.org/index.php/Samba_4.12_Features_added/changed
https://git.samba.org/?p=samba.git;a=commit;h=3fea05e0
https://git.samba.org/?p=samba.git;a=commit;h=728fabea

It is supposed to remove comments about deprecated 'write cache size',
in order to avoid confusion when reading source code and documents.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15383

Signed-off-by: Jones Syue <jonessyue@qnap.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jun  2 09:48:17 UTC 2023 on atb-devel-224

(cherry picked from commit 9c24f853a84e1435235ba58ffcaaeff7dd80f6aa)
This commit is contained in:
Jones Syue 2023-06-02 14:40:09 +08:00 committed by Jule Anger
parent 3662ddaadc
commit d49f9f4be7
4 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs-xml/smbdotconf/locking/smb2leases.xml
View File

@ -15,8 +15,6 @@
and <smbconfoption name="kernel oplocks">no</smbconfoption>.
</para>
<para>Note that the write cache won't be used for file handles with a smb2 write lease.</para>
</description>
<related>oplocks</related>

2
docs-xml/smbdotconf/tuning/aioreadsize.xml
View File

@ -6,7 +6,7 @@
<para>If this integer parameter is set to a non-zero value,
Samba will read from files asynchronously when the request size is bigger
than this value. Note that it happens only for non-chained and non-chaining
reads and when not using write cache.</para>
reads.</para>
<para>The only reasonable values for this parameter are 0 (no async I/O) and
1 (always do async I/O).</para>
<related>aio write size</related>

2
docs-xml/smbdotconf/tuning/aiowritesize.xml
View File

@ -6,7 +6,7 @@
<para>If this integer parameter is set to a non-zero value,
Samba will write to files asynchronously when the request size is bigger
than this value. Note that it happens only for non-chained and non-chaining
reads and when not using write cache.</para>
writes.</para>
<para>The only reasonable values for this parameter are 0 (no async I/O) and
1 (always do async I/O).</para>
<para>Compared to <smbconfoption name="aio read size"/> this parameter has

1
source3/smbd/smb2_read.c
View File

@ -353,7 +353,6 @@ static NTSTATUS schedule_smb2_sendfile_read(struct smbd_smb2_request *smb2req,
* Signing is active OR
* This is a compound SMB2 operation OR
* fsp is a STREAM file OR
* We're using a write cache OR
* It's not a regular file OR
* Requested offset is greater than file size OR
* there's not enough data in the file.