sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

CVE-2022-38023 s3:winbindd: also allow per domain "winbind sealed pipes:DOMAIN" and "require strong key:DOMAIN"

Browse Source 
This avoids advising insecure defaults for the global options.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15240

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Stefan Metzmacher 2022-11-30 14:59:36 +01:00
parent 1fdf1d55a5
commit d60828f639
1 changed files with 33 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
source3/winbindd/winbindd_cm.c
View File

@ -2457,6 +2457,8 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
bool retry = false; /* allow one retry attempt for expired session */ bool retry = false; /* allow one retry attempt for expired session */
const char *remote_name = NULL; const char *remote_name = NULL;
const struct sockaddr_storage *remote_sockaddr = NULL; const struct sockaddr_storage *remote_sockaddr = NULL;
bool sealed_pipes = true;
bool strong_key = true;
if (sid_check_is_our_sam(&domain->sid)) { if (sid_check_is_our_sam(&domain->sid)) {
if (domain->rodc == false || need_rw_dc == false) { if (domain->rodc == false || need_rw_dc == false) {
@ -2636,14 +2638,24 @@ retry:
anonymous: anonymous:
sealed_pipes = lp_winbind_sealed_pipes();
sealed_pipes = lp_parm_bool(-1, "winbind sealed pipes",
domain->name,
sealed_pipes);
strong_key = lp_require_strong_key();
strong_key = lp_parm_bool(-1, "require strong key",
domain->name,
strong_key);
/* Finally fall back to anonymous. */ /* Finally fall back to anonymous. */
if (lp_winbind_sealed_pipes() || lp_require_strong_key()) { if (sealed_pipes || strong_key) {
status = NT_STATUS_DOWNGRADE_DETECTED; status = NT_STATUS_DOWNGRADE_DETECTED;
DEBUG(1, ("Unwilling to make SAMR connection to domain %s " DEBUG(1, ("Unwilling to make SAMR connection to domain %s "
"without connection level security, " "without connection level security, "
"must set 'winbind sealed pipes = false' and " "must set 'winbind sealed pipes:%s = false' and "
"'require strong key = false' to proceed: %s\n", "'require strong key:%s = false' to proceed: %s\n",
domain->name, nt_errstr(status))); domain->name, domain->name, domain->name,
nt_errstr(status)));
goto done; goto done;
} }
status = cli_rpc_pipe_open_noauth(conn->cli, &ndr_table_samr, status = cli_rpc_pipe_open_noauth(conn->cli, &ndr_table_samr,
@ -2800,6 +2812,8 @@ NTSTATUS cm_connect_lsa(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
bool retry = false; /* allow one retry attempt for expired session */ bool retry = false; /* allow one retry attempt for expired session */
const char *remote_name = NULL; const char *remote_name = NULL;
const struct sockaddr_storage *remote_sockaddr = NULL; const struct sockaddr_storage *remote_sockaddr = NULL;
bool sealed_pipes = true;
bool strong_key = true;
retry: retry:
result = init_dc_connection_rpc(domain, false); result = init_dc_connection_rpc(domain, false);
@ -2961,13 +2975,24 @@ retry:
goto done; goto done;
} }
if (lp_winbind_sealed_pipes() || lp_require_strong_key()) { sealed_pipes = lp_winbind_sealed_pipes();
sealed_pipes = lp_parm_bool(-1, "winbind sealed pipes",
domain->name,
sealed_pipes);
strong_key = lp_require_strong_key();
strong_key = lp_parm_bool(-1, "require strong key",
domain->name,
strong_key);
/* Finally fall back to anonymous. */
if (sealed_pipes || strong_key) {
result = NT_STATUS_DOWNGRADE_DETECTED; result = NT_STATUS_DOWNGRADE_DETECTED;
DEBUG(1, ("Unwilling to make LSA connection to domain %s " DEBUG(1, ("Unwilling to make LSA connection to domain %s "
"without connection level security, " "without connection level security, "
"must set 'winbind sealed pipes = false' and " "must set 'winbind sealed pipes:%s = false' and "
"'require strong key = false' to proceed: %s\n", "'require strong key:%s = false' to proceed: %s\n",
domain->name, nt_errstr(result))); domain->name, domain->name, domain->name,
nt_errstr(result)));
goto done; goto done;
} }