sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

param: change default of "allocation roundup size" to 0

Browse Source 
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
This commit is contained in:
Björn Jacke 2019-06-19 13:04:55 +02:00 committed by Bjoern Jacke
parent 37b3c6375b
commit d6b8cbc8f7
4 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
docs-xml/smbdotconf/tuning/allocationroundupsize.xml
View File

@ -4,17 +4,21 @@
xmlns:samba="http://www.samba.org/samba/DTD/samba-doc">
<description>
<para>This parameter allows an administrator to tune the
allocation size reported to Windows clients. The default
size of 1Mb generally results in improved Windows client
performance. However, rounding the allocation size may cause
allocation size reported to Windows clients. This is only
useful for old SMB1 clients because modern SMB dialects
eliminated that bottleneck and have better performance by
default. Using this parameter may cause
difficulties for some applications, e.g. MS Visual Studio.
If the MS Visual Studio compiler starts to crash with an
internal error, set this parameter to zero for this share.
Settings this parameter to a large value can also cause
small files to allocate more space on the disk than
needed.
</para>
<para>The integer parameter specifies the roundup size in bytes.</para>
</description>
<value type="default">1048576</value>
<value type="example">0<comment>(to disable roundups)</comment></value>
<value type="default">0</value>
<value type="example">1048576<comment>(to set it to the former default of 1 MiB)</comment></value>
</samba:parameter>

2
lib/param/loadparm.c
View File

@ -2889,8 +2889,6 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx)
lpcfg_do_global_parameter(lp_ctx, "show add printer wizard", "yes");
lpcfg_do_global_parameter(lp_ctx, "allocation roundup size", "1048576");
lpcfg_do_global_parameter(lp_ctx, "ldap page size", "1000");
lpcfg_do_global_parameter(lp_ctx, "kernel share modes", "yes");

3
source3/include/local.h
View File

@ -151,9 +151,6 @@
/* the maximum age in seconds of a password. Should be a lp_ parameter */
#define MAX_PASSWORD_AGE (21*24*60*60)
/* Default allocation roundup. */
#define SMB_ROUNDUP_ALLOCATION_SIZE 0x100000
/* shall we deny oplocks to clients that get timeouts? */
#define FASCIST_OPLOCK_BACKOFF 1

1
source3/param/loadparm.c
View File

@ -236,7 +236,6 @@ static const struct loadparm_service _sDefault =
.acl_map_full_control = true,
.acl_group_control = false,
.acl_allow_execute_always = false,
.allocation_roundup_size = SMB_ROUNDUP_ALLOCATION_SIZE,
.aio_read_size = 1,
.aio_write_size = 1,
.map_readonly = MAP_READONLY_NO,