sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

s4-pvfs: fixed access check failure in SFILEINFO test

Browse Source 
matching windows behaviour is not always the right thing to do!
This commit is contained in:
Andrew Tridgell 2009-11-27 14:22:29 +11:00
parent d5387edb88
commit d78921d78c
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source4/ntvfs/posix/pvfs_open.c
View File

@ -1941,15 +1941,12 @@ NTSTATUS pvfs_can_update_file_size(struct pvfs_state *pvfs,
NTCREATEX_SHARE_ACCESS_WRITE |
NTCREATEX_SHARE_ACCESS_DELETE;
/*
* I would have thought that we would need to pass
* SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA here too
*
* But you only need SEC_FILE_WRITE_ATTRIBUTE permissions
* to set the filesize.
*
* --metze
* this code previous set only SEC_FILE_WRITE_ATTRIBUTE, with
* a comment that this seemed to be wrong, but matched windows
* behaviour. It now appears that this windows behaviour is
* just a bug.
*/
access_mask = SEC_FILE_WRITE_ATTRIBUTE;
access_mask = SEC_FILE_WRITE_ATTRIBUTE | SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA;
delete_on_close = false;
break_to_none = true;