sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-02 00:23:50 +03:00
Code Activity

r17256: fix 2 crash bugs, which are introduced by making parameters

Browse Source 
ref pointers!

I'm sure there're more places and more care is needed when idl files
are changed. Hopefully testing against windows in the build farm
find such bugs in future...

Why is in the client library this no more possible:

NTSTATUS foo([in,out,ref] uint8 *foo);

and then just

r.in.foo = &foo;
status = dcerpc_foo(p, mem_ctx, &r);

and r.out.foo will set to r.in.foo via pidl magic,
that worked some time ago...

metze
This commit is contained in:
Stefan Metzmacher
2006-07-26 12:25:16 +00:00
committed by Gerald (Jerry) Carter
parent 7b05c007ea
commit d8952f00c7
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/torture/rpc/wkssvc.c
View File

@@ -30,11 +30,13 @@ static BOOL test_NetWkstaGetInfo(struct dcerpc_pipe *p,
{
NTSTATUS status;
struct wkssvc_NetWkstaGetInfo r;
union wkssvc_NetWkstaInfo info;
uint16_t levels[] = {100, 101, 102, 502};
int i;
BOOL ret = True;
r.in.server_name = dcerpc_server_name(p);
r.out.info = &info;
for (i=0;i<ARRAY_SIZE(levels);i++) {
r.in.level = levels[i];
@@ -71,6 +73,7 @@ static BOOL test_NetWkstaTransportEnum(struct dcerpc_pipe *p,
r.in.ctr = &ctr;
r.in.max_buffer = (uint32_t)-1;
r.in.resume_handle = &resume_handle;
r.out.ctr = &ctr;
r.out.resume_handle = &resume_handle;
printf("testing NetWkstaTransportEnum\n");