sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-03 01:18:10 +03:00
Code

ldb:dn_compare_base: avoid unlikely int overflow

Browse Source 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Douglas Bagnall 2024-08-23 10:14:04 +12:00 committed by Douglas Bagnall
parent 4fa67dee9a
commit d8b7712c53
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/ldb/common/ldb_dn.c
View File

@ -1062,13 +1062,15 @@ int ldb_dn_compare_base(struct ldb_dn *base, struct ldb_dn *dn)
if (base->linearized && dn->linearized && dn->special == base->special) { if (base->linearized && dn->linearized && dn->special == base->special) {
/* try with a normal compare first, if we are lucky /* try with a normal compare first, if we are lucky
* we will avoid exploding and casefolding */ * we will avoid exploding and casefolding */
int dif; size_t len_dn = strlen(dn->linearized);
dif = strlen(dn->linearized) - strlen(base->linearized); size_t len_base = strlen(base->linearized);
if (dif < 0) {
return dif; if (len_dn < len_base) {
return -1;
} }
if (strcmp(base->linearized, if (strcmp(base->linearized,
&dn->linearized[dif]) == 0) { &dn->linearized[len_dn - len_base]) == 0) {
return 0; return 0;
} }
} }