sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

pytest:sddl: let hex numbers differ in case (0xa == 0xA)

Browse Source 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2023-04-16 18:43:40 +12:00 committed by Andrew Bartlett
parent 030ce22f52
commit de6d470063
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
python/samba/tests/sddl.py
View File

@ -56,7 +56,11 @@ class SddlDecodeEncodeBase(TestCase):
sddl = sd1.as_sddl(self.domain_sid)
sd2 = security.descriptor.from_sddl(sddl, self.domain_sid)
self.assertEqual(sd1, sd2)
self.assertEqual(sddl, canonical)
if '0X' in canonical.upper():
# let's chill out about case in hex numbers.
self.assertEqual(sddl.upper(), canonical.upper())
else:
self.assertEqual(sddl, canonical)
def _test_sddl_should_fail_with_args(self, s, canonical):
with self.assertRaises(ValueError):

1
selftest/knownfail.d/sddl
View File

@ -1,4 +1,3 @@
^samba.tests.sddl.+.SddlNonCanonical.test_sddl_D:.A;;GA;;;S-1-5000000000-30-40..none
^samba.tests.sddl.+.SddlShouldFail.test_sddl_should_fail_D:.A;;0x.75bcd15;;;LG..none
^samba.tests.sddl.+.SddlShouldFail.test_sddl_should_fail_D:.A;;0x75bcd15 ;;;LG..none
^samba.tests.sddl.+.SddlShouldFail.test_sddl_should_fail_D:.A;;123456789.;;;LG..none