sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

r16361: Fix Klocwork ID 1731 1770 1771 1775 1796

Browse Source 
Volker
(This used to be commit 8a5cebc19e4709399976efe9e3ba3bf29249620a)
This commit is contained in:
Volker Lendecke 2006-06-19 19:41:56 +00:00 committed by Gerald (Jerry) Carter
parent e7fc37cf0f
commit dfa4760eea
4 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source3/nsswitch/winbindd_ads.c
View File

@ -904,7 +904,11 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
members = NULL;
num_members = 0;
attrs = TALLOC_ARRAY(mem_ctx, const char *, 3);
if ((attrs = TALLOC_ARRAY(mem_ctx, const char *, 3)) == NULL) {
status = NT_STATUS_NO_MEMORY;
goto done;
}
attrs[1] = talloc_strdup(mem_ctx, "usnChanged");
attrs[2] = NULL;

3
source3/nsswitch/winbindd_cache.c
View File

@ -276,7 +276,7 @@ static BOOL centry_sid(struct cache_entry *centry, TALLOC_CTX *mem_ctx, DOM_SID
{
char *sid_string;
sid_string = centry_string(centry, mem_ctx);
if (!string_to_sid(sid, sid_string)) {
if ((sid_string == NULL) || (!string_to_sid(sid, sid_string))) {
return False;
}
return True;
@ -2136,6 +2136,7 @@ void wcache_flush_cache(void)
if (!wcache->tdb) {
DEBUG(0,("Failed to open winbindd_cache.tdb!\n"));
return;
}
tdb_traverse(wcache->tdb, traverse_fn_cleanup, NULL);

3
source3/nsswitch/winbindd_cm.c
View File

@ -723,6 +723,9 @@ static BOOL find_new_dc(TALLOC_CTX *mem_ctx,
if ((num_dcnames == 0) || (num_dcnames != num_addrs))
return False;
if ((addrs == NULL) || (dcnames == NULL))
return False;
if ( !open_any_socket_out(addrs, num_addrs, 10000, &fd_index, fd) )
{
for (i=0; i<num_dcs; i++) {

5
source3/nsswitch/winbindd_misc.c
View File

@ -158,7 +158,10 @@ enum winbindd_result winbindd_dual_list_trusted_domains(struct winbindd_domain *
/* This is a bit excessive, but the extra data sooner or later will be
talloc'ed */
extra_data_len = strlen(extra_data);
extra_data_len = 0;
if (extra_data != NULL) {
extra_data_len = strlen(extra_data);
}
if (extra_data_len > 0) {
state->response.extra_data.data = SMB_STRDUP(extra_data);