sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-08 04:58:40 +03:00
Code

possibly fix the 15000 user problem

Browse Source 
I think its caused by a rpc operation failing and us giving invalid
data back to the cache layer. Using talloc_zero() should solve this.
This commit is contained in:
Andrew Tridgell -
parent 91a3ccd3e7
commit dfa990170b
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source/nsswitch/winbindd_ads.c
View File

@ -220,7 +220,7 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
goto done;
}
(*info) = talloc(mem_ctx, count * sizeof(**info));
(*info) = talloc_zero(mem_ctx, count * sizeof(**info));
if (!*info) {
status = NT_STATUS_NO_MEMORY;
goto done;
@ -308,7 +308,7 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
goto done;
}
(*info) = talloc(mem_ctx, count * sizeof(**info));
(*info) = talloc_zero(mem_ctx, count * sizeof(**info));
if (!*info) {
status = NT_STATUS_NO_MEMORY;
goto done;
@ -628,7 +628,7 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
}
count = ads_pull_sids(ads, mem_ctx, msg, "tokenGroups", &sids) + 1;
(*user_gids) = (uint32 *)talloc(mem_ctx, sizeof(uint32) * count);
(*user_gids) = (uint32 *)talloc_zero(mem_ctx, sizeof(uint32) * count);
(*user_gids)[(*num_groups)++] = primary_group;
for (i=1;i<count;i++) {
@ -690,9 +690,9 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
goto done;
}
(*rid_mem) = talloc(mem_ctx, sizeof(uint32) * count);
(*name_types) = talloc(mem_ctx, sizeof(uint32) * count);
(*names) = talloc(mem_ctx, sizeof(char *) * count);
(*rid_mem) = talloc_zero(mem_ctx, sizeof(uint32) * count);
(*name_types) = talloc_zero(mem_ctx, sizeof(uint32) * count);
(*names) = talloc_zero(mem_ctx, sizeof(char *) * count);
for (msg = ads_first_entry(ads, res); msg; msg = ads_next_entry(ads, msg)) {
uint32 atype, rid;

4
source/nsswitch/winbindd_rpc.c
View File

@ -447,8 +447,8 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
#define MAX_LOOKUP_RIDS 900
*names = talloc(mem_ctx, *num_names * sizeof(char *));
*name_types = talloc(mem_ctx, *num_names * sizeof(uint32));
*names = talloc_zero(mem_ctx, *num_names * sizeof(char *));
*name_types = talloc_zero(mem_ctx, *num_names * sizeof(uint32));
for (i = 0; i < *num_names; i += MAX_LOOKUP_RIDS) {
int num_lookup_rids = MIN(*num_names - i, MAX_LOOKUP_RIDS);