sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-09-09 01:44:21 +03:00
Code Activity

samlogon_cache: use a talloc_stackframe inside netsamlogon_cache_store.

Browse Source 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Günther Deschner
2014-07-09 13:36:06 +02:00
parent 2a790a5aff
commit e0128fd07e
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source3/libsmb/samlogon_cache.c
View File

@@ -125,7 +125,7 @@ bool netsamlogon_cache_store(const char *username, struct netr_SamInfo3 *info3)
bool result = false; bool result = false;
struct dom_sid user_sid; struct dom_sid user_sid;
time_t t = time(NULL); time_t t = time(NULL);
TALLOC_CTX *mem_ctx; TALLOC_CTX *tmp_ctx = talloc_stackframe();
DATA_BLOB blob; DATA_BLOB blob;
enum ndr_err_code ndr_err; enum ndr_err_code ndr_err;
struct netsamlogoncache_entry r; struct netsamlogoncache_entry r;
@@ -149,11 +149,6 @@ bool netsamlogon_cache_store(const char *username, struct netr_SamInfo3 *info3)
/* Prepare data */ /* Prepare data */
if (!(mem_ctx = talloc( NULL, int))) {
DEBUG(0,("netsamlogon_cache_store: talloc() failed!\n"));
return false;
}
/* only Samba fills in the username, not sure why NT doesn't */ /* only Samba fills in the username, not sure why NT doesn't */
/* so we fill it in since winbindd_getpwnam() makes use of it */ /* so we fill it in since winbindd_getpwnam() makes use of it */
@@ -168,11 +163,11 @@ bool netsamlogon_cache_store(const char *username, struct netr_SamInfo3 *info3)
NDR_PRINT_DEBUG(netsamlogoncache_entry, &r); NDR_PRINT_DEBUG(netsamlogoncache_entry, &r);
} }
ndr_err = ndr_push_struct_blob(&blob, mem_ctx, &r, ndr_err = ndr_push_struct_blob(&blob, tmp_ctx, &r,
(ndr_push_flags_fn_t)ndr_push_netsamlogoncache_entry); (ndr_push_flags_fn_t)ndr_push_netsamlogoncache_entry);
if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) { if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
DEBUG(0,("netsamlogon_cache_store: failed to push entry to cache\n")); DEBUG(0,("netsamlogon_cache_store: failed to push entry to cache\n"));
TALLOC_FREE(mem_ctx); TALLOC_FREE(tmp_ctx);
return false; return false;
} }
@@ -183,7 +178,7 @@ bool netsamlogon_cache_store(const char *username, struct netr_SamInfo3 *info3)
result = true; result = true;
} }
TALLOC_FREE(mem_ctx); TALLOC_FREE(tmp_ctx);
return result; return result;
} }