From e168a6738b287524738615046f65a3298d717b70 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 23 Nov 2018 09:03:13 +0100 Subject: [PATCH] winbind: Fix "wbint_Principals" definition A signed integer does not make any sense for an IDL array length Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- librpc/idl/winbind.idl | 2 +- source3/winbindd/wb_query_user_list.c | 2 +- source3/winbindd/winbindd_lookuprids.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/librpc/idl/winbind.idl b/librpc/idl/winbind.idl index f5e3507bff5..258dd284ad5 100644 --- a/librpc/idl/winbind.idl +++ b/librpc/idl/winbind.idl @@ -120,7 +120,7 @@ interface winbind } wbint_Principal; typedef [public] struct { - int num_principals; + uint32 num_principals; [size_is(num_principals)] wbint_Principal principals[]; } wbint_Principals; diff --git a/source3/winbindd/wb_query_user_list.c b/source3/winbindd/wb_query_user_list.c index 6d699875e9b..5e80aae8469 100644 --- a/source3/winbindd/wb_query_user_list.c +++ b/source3/winbindd/wb_query_user_list.c @@ -93,7 +93,7 @@ static void wb_query_user_list_done(struct tevent_req *subreq) struct wb_query_user_list_state *state = tevent_req_data( req, struct wb_query_user_list_state); NTSTATUS status, result; - int i; + uint32_t i; status = dcerpc_wbint_LookupRids_recv(subreq, state, &result); TALLOC_FREE(subreq); diff --git a/source3/winbindd/winbindd_lookuprids.c b/source3/winbindd/winbindd_lookuprids.c index 6d0c0efd429..ed5d951e7de 100644 --- a/source3/winbindd/winbindd_lookuprids.c +++ b/source3/winbindd/winbindd_lookuprids.c @@ -117,7 +117,7 @@ NTSTATUS winbindd_lookuprids_recv(struct tevent_req *req, req, struct winbindd_lookuprids_state); NTSTATUS status; char *result; - int i; + uint32_t i; if (tevent_req_is_nterror(req, &status)) { DEBUG(5, ("Lookuprids failed: %s\n",nt_errstr(status)));