sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code

r18024: The %c sscanf format I'm using doesn't null terminate.

Browse Source 
Andrew Bartlett
(This used to be commit 1920cb8b39)
This commit is contained in:
Andrew Bartlett 2006-09-04 01:59:23 +00:00 committed by Gerald (Jerry) Carter
parent 36ca11b00a
commit e21e8379a2
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source4/libcli/ldap/ldap_client.c
View File

@ -311,9 +311,12 @@ struct composite_context *ldap_connect_send(struct ldap_connection *conn,
if (!NT_STATUS_IS_OK(status)) {
return NULL;
}
talloc_steal(conn, conn->sock);
SMB_ASSERT(sizeof(protocol)>10);
SMB_ASSERT(sizeof(path)>1024);
/* The %c specifier doesn't null terminate :-( */
ZERO_STRUCT(path);
ret = sscanf(url, "%10[^:]://%1025c", protocol, path);
if (ret < 2) {
composite_error(state->ctx, NT_STATUS_INVALID_PARAMETER);