sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

idmap: Fix CID 1363261 Resource leak

Browse Source 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2018-04-06 11:04:24 +02:00 committed by Jeremy Allison
parent ad90835c2b
commit e29eaa43f5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source3/winbindd/idmap_ad_nss.c
View File

@ -290,7 +290,7 @@ static NTSTATUS nss_ad_map_from_alias( TALLOC_CTX *mem_ctx,
LDAPMessage *msg = NULL;
ADS_STATUS ads_status = ADS_ERROR_NT(NT_STATUS_UNSUCCESSFUL);
NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
char *username;
char *username = NULL;
struct idmap_domain *dom;
struct idmap_ad_context *ctx = NULL;
@ -339,7 +339,8 @@ static NTSTATUS nss_ad_map_from_alias( TALLOC_CTX *mem_ctx,
username = ads_pull_string(ctx->ads, mem_ctx, msg,
"sAMAccountName");
if (!username) {
return NT_STATUS_OBJECT_NAME_NOT_FOUND;
nt_status = NT_STATUS_OBJECT_NAME_NOT_FOUND;
goto done;
}
*name = talloc_asprintf(mem_ctx, "%s\\%s",
@ -353,6 +354,7 @@ static NTSTATUS nss_ad_map_from_alias( TALLOC_CTX *mem_ctx,
nt_status = NT_STATUS_OK;
done:
TALLOC_FREE(username);
TALLOC_FREE(filter);
if (msg) {
ads_msgfree(ctx->ads, msg);