sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

dsdb: Slightly simplify dsdb_trust_get_incoming_passwords()

Browse Source 
Use talloc_memdup() instead of a manual copy.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2023-10-06 08:00:06 +02:00 committed by Jeremy Allison
parent 7bc1fa707d
commit e2e5ae1eb2
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source4/dsdb/common/util_trusts.c
View File

@ -2746,15 +2746,15 @@ NTSTATUS dsdb_trust_get_incoming_passwords(struct ldb_message *msg,
}
if (_current != NULL) {
*_current = talloc(mem_ctx, struct samr_Password);
*_current = talloc_memdup(mem_ctx, current, sizeof(*current));
if (*_current == NULL) {
TALLOC_FREE(frame);
return NT_STATUS_NO_MEMORY;
}
**_current = *current;
}
if (_previous != NULL) {
*_previous = talloc(mem_ctx, struct samr_Password);
*_previous =
talloc_memdup(mem_ctx, previous, sizeof(*previous));
if (*_previous == NULL) {
if (_current != NULL) {
TALLOC_FREE(*_current);
@ -2762,7 +2762,6 @@ NTSTATUS dsdb_trust_get_incoming_passwords(struct ldb_message *msg,
TALLOC_FREE(frame);
return NT_STATUS_NO_MEMORY;
}
**_previous = *previous;
}
ZERO_STRUCTP(current);
ZERO_STRUCTP(previous);