sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-08 04:58:40 +03:00
Code

Fix a valgrind error in winbind

Browse Source 
When looking for idle clients, we dereferenced state->response. As this is
dynamically allocated now, the proper test is whether state->response exists at
all. This is the case when an async operation is in process at that moment.
This commit is contained in:
Volker Lendecke 2009-07-26 20:20:50 +02:00
parent cdd7a5208f
commit e30509f037
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source3/winbindd/winbindd.c
View File

@ -664,6 +664,7 @@ static void winbind_client_response_written(struct tevent_req *req)
}
TALLOC_FREE(state->mem_ctx);
state->response = NULL;
req = wb_req_read_send(state, winbind_event_context(), state->sock,
WINBINDD_MAX_EXTRA_DATA);
@ -816,7 +817,7 @@ static bool remove_idle_client(void)
int nidle = 0;
for (state = winbindd_client_list(); state; state = state->next) {
if (state->response->result != WINBINDD_PENDING &&
if (state->response == NULL &&
!state->getpwent_state && !state->getgrent_state) {
nidle++;
if (!last_access || state->last_access < last_access) {