sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code

s4:samldb LDB module - don't change the "primaryGroupId" on LDB modifications unless we are a computer/dc/rodc

Browse Source 
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
This commit is contained in:
Matthieu Patou 2011-05-21 11:56:45 +04:00 committed by Matthias Dieter Wallnöfer
parent 67bf5cfc08
commit e3aa200a14
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source4/dsdb/samdb/ldb_modules/samldb.c
View File

@ -1219,6 +1219,12 @@ static int samldb_prim_group_trigger(struct samldb_ctx *ac)
return ret;
}
/**
* This function is called on a LDB modify. It performs some additions/changes
* on the current LDB message. Changes depend on the value of
* userAccountControl.
*/
static int samldb_user_account_control_change(struct samldb_ctx *ac)
{
struct ldb_context *ldb = ldb_module_get_ctx(ac->module);
@ -1278,7 +1284,16 @@ static int samldb_user_account_control_change(struct samldb_ctx *ac)
el->flags = LDB_FLAG_MOD_REPLACE;
}
if (!ldb_msg_find_element(ac->msg, "primaryGroupID")) {
/*
* If the account has UF_SERVER_TRUST_ACCOUNT or
* UF_WORKSTATION_TRUST_ACCOUNT then change the group
* as it's either a workstation, a RODC, or a DC.
*
* If not it might be just a user that we are enabling
* and in this case we don't want to change its default group.
*/
if (user_account_control & (UF_SERVER_TRUST_ACCOUNT| UF_WORKSTATION_TRUST_ACCOUNT) &&
!ldb_msg_find_element(ac->msg, "primaryGroupID")) {
uint32_t rid = ds_uf2prim_group_rid(user_account_control);
ret = samdb_msg_add_uint(ldb, ac->msg, ac->msg,
"primaryGroupID", rid);